Fix centered modal scrolling issue #30244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like your solution @ysds , Its more better and simple. Thanks 👍 |
MartijnCuppens
approved these changes
Feb 24, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Mar 4, 2020
Use the `min-content` property.
XhmikosR
pushed a commit
that referenced
this pull request
Mar 9, 2020
Use the `min-content` property.
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
Use the `min-content` property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another solution of #30003.
You can see the issue in the vertical modal demo. This behavior occurs when the browser UI (address bar) is displayed.
This PR fix it by using the
min-contentproperty.Preview: https://deploy-preview-30244--twbs-bootstrap.netlify.com/docs/4.3/components/modal/#vertically-centered